[radeon agp] add blacklist for thinkpad T40p

[radeon agp] add blacklist for thinkpad T40p

[Pavel Machek]

Thinkpad T40p needs agpmode 1.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
index fe994aa..c77d349 100644
--- a/drivers/gpu/drm/radeon/radeon_agp.c
+++ b/drivers/gpu/drm/radeon/radeon_agp.c
@@ -54,6 +54,9 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
 	/* Intel 82855PM host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (lp #195051) */
 	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4e50,
 		PCI_VENDOR_ID_IBM, 0x0550, 1},
+	/* Intel 82855PM host bridge / RV250/M9 GL [Mobility FireGL 9000/Radeon 9000] needs AGPMode 1 (Thinkpad T40p) */
+	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
+		PCI_VENDOR_ID_IBM, 0x054d, 1},
 	/* Intel 82855PM host bridge / Mobility M7 needs AGPMode 1 */
 	{ PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c57,
 		PCI_VENDOR_ID_IBM, 0x0530, 1},

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [radeon agp] add blacklist for thinkpad T40p

[Alex Deucher]

On Sat, Nov 28, 2015 at 4:01 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
> Thinkpad T40p needs agpmode 1.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Seems odd that this wouldn't have been found earlier given how popular
thinkpads are.  Applied.  Thanks,

Alex

>
> diff --git a/drivers/gpu/drm/radeon/radeon_agp.c b/drivers/gpu/drm/radeon/radeon_agp.c
> index fe994aa..c77d349 100644
> --- a/drivers/gpu/drm/radeon/radeon_agp.c
> +++ b/drivers/gpu/drm/radeon/radeon_agp.c
> @@ -54,6 +54,9 @@ static struct radeon_agpmode_quirk radeon_agpmode_quirk_list[] = {
>         /* Intel 82855PM host bridge / Mobility 9600 M10 RV350 Needs AGPMode 1 (lp #195051) */
>         { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4e50,
>                 PCI_VENDOR_ID_IBM, 0x0550, 1},
> +       /* Intel 82855PM host bridge / RV250/M9 GL [Mobility FireGL 9000/Radeon 9000] needs AGPMode 1 (Thinkpad T40p) */
> +       { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c66,
> +               PCI_VENDOR_ID_IBM, 0x054d, 1},
>         /* Intel 82855PM host bridge / Mobility M7 needs AGPMode 1 */
>         { PCI_VENDOR_ID_INTEL, 0x3340, PCI_VENDOR_ID_ATI, 0x4c57,
>                 PCI_VENDOR_ID_IBM, 0x0530, 1},
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [radeon agp] add blacklist for thinkpad T40p

[Emil Velikov]

On 30 November 2015 at 19:47, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Sat, Nov 28, 2015 at 4:01 PM, Pavel Machek <pavel@ucw.cz> wrote:
>>
>> Thinkpad T40p needs agpmode 1.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Seems odd that this wouldn't have been found earlier given how popular
> thinkpads are.  Applied.  Thanks,
>
Wondering if it wouldn't be better to apply these restrictions within
the AGP driver. I have a vague recollection that (at least?) some of
these are chipset limitations/bugs ?

Thanks
Emil

Re: [radeon agp] add blacklist for thinkpad T40p

[Alex Deucher]

On Wed, Dec 2, 2015 at 6:15 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 30 November 2015 at 19:47, Alex Deucher <alexdeucher@gmail.com> wrote:
>> On Sat, Nov 28, 2015 at 4:01 PM, Pavel Machek <pavel@ucw.cz> wrote:
>>>
>>> Thinkpad T40p needs agpmode 1.
>>>
>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>
>> Seems odd that this wouldn't have been found earlier given how popular
>> thinkpads are.  Applied.  Thanks,
>>
> Wondering if it wouldn't be better to apply these restrictions within
> the AGP driver. I have a vague recollection that (at least?) some of
> these are chipset limitations/bugs ?

I think it's probably better in the GPU drivers.  AGP was always
problematic.  There are a number of quirks that were necessary for
some users but not others on the same hardware.  Additionally, the
combination of vendors or even driver versions/behaviors were
problematic.  E.g., with UMS, the drivers didn't use much gart since
there was just a single static allocation.  Once we switched to KMS,
lots of new bugs surfaced.  Chipset A plus GPU vendor B worked fined,
but chipset A with GPU vendor C was problematic.

Alex

Re: [radeon agp] add blacklist for thinkpad T40p

[Emil Velikov]

On 2 December 2015 at 16:33, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Wed, Dec 2, 2015 at 6:15 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
>> On 30 November 2015 at 19:47, Alex Deucher <alexdeucher@gmail.com> wrote:
>>> On Sat, Nov 28, 2015 at 4:01 PM, Pavel Machek <pavel@ucw.cz> wrote:
>>>>
>>>> Thinkpad T40p needs agpmode 1.
>>>>
>>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>>
>>> Seems odd that this wouldn't have been found earlier given how popular
>>> thinkpads are.  Applied.  Thanks,
>>>
>> Wondering if it wouldn't be better to apply these restrictions within
>> the AGP driver. I have a vague recollection that (at least?) some of
>> these are chipset limitations/bugs ?
>
> I think it's probably better in the GPU drivers.  AGP was always
> problematic.  There are a number of quirks that were necessary for
> some users but not others on the same hardware.  Additionally, the
> combination of vendors or even driver versions/behaviors were
> problematic.  E.g., with UMS, the drivers didn't use much gart since
> there was just a single static allocation.  Once we switched to KMS,
> lots of new bugs surfaced.  Chipset A plus GPU vendor B worked fined,
> but chipset A with GPU vendor C was problematic.
>
Looking at how many cases with identical vendor/device (yet differing
sub vendor/device) are there, plus some of these also available in
nouveau I'm wondering if it's truly a case of things "working" for
some as opposed to different test(ing procedure) being applied. That
assumption comes along nicely with how 'delayed' this report is.

That said I'm not pushing on anything, just pointing out the pattern I see.

Emil