public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing
Date: Sun, 29 Nov 2015 20:50:18 +0100	[thread overview]
Message-ID: <201511292050.18883@pali> (raw)
In-Reply-To: <20151126145556.GA9371@eudyptula.hq.kempniu.pl>

[-- Attachment #1: Type: Text/Plain, Size: 3344 bytes --]

On Thursday 26 November 2015 15:55:56 Michał Kępień wrote: 
> > >  	/* Shortcut and audio panel keys */
> > > 
> > > -	{ KE_IGNORE, 0xe025, { KEY_RESERVED } },
> > > +	{ KE_KEY, 0xe025, { KEY_PROG4 } },
> > > 
> > >  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
> > 
> > I'm trying to figure out if those two keys are really reported via
> > keyboard controller or not. They were added 4 years ago in commit
> > f1566f0dc07ec9b5409b348070f5a700032d7881. But from bug report
> > http://bugs.launchpad.net/bugs/815914 there is no information if
> > those two keys are really reported by keyboard controller or not.
> > 
> > And if not our problem could be easier...
> 
> That would indeed be sweet as this patch could then be shrinked to
> just changing the entry in the sparse keymap.  Does anyone have a
> Dell XPS L502X handy?  Also, any ideas for making sure no other
> model is generating that keypress?

And now I have info how keys are reported on Dell XPS L502X. Sadly it is 
worse as I expected :-( Here is output from Jean-Louis Dupond notebook:

$ sudo /usr/bin/input-events 4
/dev/input/event4
    bustype : BUS_I8042
    vendor  : 0x1
    product : 0x1
    version : 43841
    name    : "AT Translated Set 2 keyboard"
    phys    : "isa0060/serio0/input0"
    bits ev : EV_SYN EV_KEY EV_MSC EV_LED EV_REP

waiting for events

10:26:29.945739: EV_MSC MSC_SCAN 219
10:26:29.945739: EV_KEY KEY_LEFTMETA (0x7d) pressed
10:26:29.945739: EV_SYN code=0 value=0
10:26:29.946468: EV_MSC MSC_SCAN 45
10:26:29.946468: EV_KEY KEY_X (0x2d) pressed
10:26:29.946468: EV_SYN code=0 value=0
10:26:29.948469: EV_MSC MSC_SCAN 45
10:26:29.948469: EV_KEY KEY_X (0x2d) released
10:26:29.948469: EV_SYN code=0 value=0
10:26:29.951473: EV_MSC MSC_SCAN 219
10:26:29.951473: EV_KEY KEY_LEFTMETA (0x7d) released
10:26:29.951473: EV_SYN code=0 value=0
x

(Press+release first key with name "Windows Mobility Center control")
(key X was printed to console)

10:26:32.898689: EV_MSC MSC_SCAN 133
10:26:32.898689: EV_KEY KEY_BRIGHTNESSDOWN (0xe0) pressed
10:26:32.898689: EV_SYN code=0 value=0
10:26:32.898730: EV_MSC MSC_SCAN 133
10:26:32.898730: EV_KEY KEY_BRIGHTNESSDOWN (0xe0) released
10:26:32.898730: EV_SYN code=0 value=0

(Press+release second key with name "Instant launch control")

10:26:35.090018: EV_MSC MSC_SCAN 132
10:26:35.090018: EV_KEY KEY_NEXTSONG (0xa3) pressed
10:26:35.090018: EV_SYN code=0 value=0
10:26:35.092765: EV_MSC MSC_SCAN 132
10:26:35.092765: EV_KEY KEY_NEXTSONG (0xa3) released
10:26:35.092765: EV_SYN code=0 value=0

(Press+release third key with name "Audio control-panel control")

As you can see events are send also via keyboard controller!

Key codes are configured by userspace (udev/systemd) and looks like 
there is bug in userspace rules (reason for brightnes or nextsong), see:
https://wiki.ubuntu.com/HardwareSupport/Machines/Laptops/Dell/XPS/15

So it is not easy to make both machines (Dell XPS L502X and Dell Vostro 
V131) works correctly :-( At least I do not see how.

And that mapping "Windows Mobility Center control" key to combination of 
two keys (KEY_LEFTMETA + X) is some total stupid nonsense...

If anybody has idea how to fix this big firmware/BIOS mess please let us 
know...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2015-11-29 19:50 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 14:18 [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing Michał Kępień
2015-11-26 14:41 ` Pali Rohár
2015-11-26 14:55   ` Michał Kępień
2015-11-29 19:50     ` Pali Rohár [this message]
2015-11-30 14:14       ` Michał Kępień
2015-11-30 14:37         ` Pali Rohár
2015-11-30 14:54           ` Michał Kępień
2015-11-30 20:55             ` Darren Hart
2015-11-30 21:15 ` Darren Hart
2015-12-01  8:47   ` Michał Kępień
2015-12-01 19:51   ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień
2015-12-04  1:16     ` Darren Hart
2015-12-04  8:56       ` Pali Rohár
2015-12-04 13:27         ` Michał Kępień
2016-01-11 19:12           ` Darren Hart
2016-01-11 20:07             ` Pali Rohár
2016-01-21  9:04               ` Pali Rohár
2016-01-21 10:52                 ` Michał Kępień
2016-01-21 13:44                   ` Pali Rohár
2016-01-21 14:56                     ` Michał Kępień
2016-01-21 15:42                       ` Pali Rohár
2016-01-22 11:08                         ` Michał Kępień
2016-02-16 14:50                 ` [PATCH v3 0/5] Process Dell Instant Launch hotkey on Vostro V131 and Inspiron M5110 Michał Kępień
2016-02-16 14:50                   ` [PATCH v3 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-02-16 14:50                   ` [PATCH v3 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-02-16 14:50                   ` [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-02-16 15:17                     ` Pali Rohár
2016-02-16 21:53                       ` Michał Kępień
2016-02-20  1:24                     ` Darren Hart
2016-02-22  8:56                       ` Michał Kępień
2016-02-22  9:03                         ` Pali Rohár
2016-02-22  9:13                           ` Michał Kępień
2016-02-22 21:17                         ` Darren Hart
2016-02-16 14:50                   ` [PATCH v3 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-02-16 14:50                   ` [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-02-16 15:22                     ` Pali Rohár
2016-02-16 22:03                       ` Michał Kępień
2016-02-17 11:42                         ` Pali Rohár
2016-02-17 12:01                           ` Michał Kępień
2016-02-17 12:08                             ` Pali Rohár
2016-02-18  8:25                               ` Michał Kępień
2016-02-24  7:20                   ` [PATCH v4 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień
2016-02-24  7:20                     ` [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-02-29 12:52                       ` Pali Rohár
2016-02-29 20:22                         ` Michał Kępień
2016-02-29 20:24                           ` Pali Rohár
2016-02-29 20:41                             ` Michał Kępień
2016-02-29 22:50                               ` Darren Hart
2016-03-02 11:49                                 ` Michał Kępień
2016-03-03 11:38                                   ` Pali Rohár
2016-02-24  7:20                     ` [PATCH v4 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-02-29 12:53                       ` Pali Rohár
2016-02-24  7:20                     ` [PATCH v4 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-02-29 12:57                       ` Pali Rohár
2016-02-24  7:20                     ` [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-02-29 12:59                       ` Pali Rohár
2016-02-29 20:31                         ` Michał Kępień
2016-02-29 20:39                           ` Pali Rohár
2016-02-29 20:49                             ` Michał Kępień
2016-02-29 20:56                               ` Pali Rohár
2016-02-29 23:00                                 ` Darren Hart
2016-03-02 12:35                                   ` Michał Kępień
2016-03-03 17:16                                     ` Darren Hart
2016-03-03 18:46                                       ` Michał Kępień
2016-03-03 20:47                                         ` Darren Hart
2016-02-29 23:00                           ` Darren Hart
2016-02-24  7:20                     ` [PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-02-29 13:00                       ` Pali Rohár
2016-03-04 13:09                     ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień
2016-03-04 13:09                       ` [PATCH v5 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień
2016-03-04 13:09                       ` [PATCH v5 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień
2016-03-04 13:09                       ` [PATCH v5 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień
2016-03-04 13:09                       ` [PATCH v5 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień
2016-03-04 13:09                       ` [PATCH v5 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień
2016-03-07  8:27                       ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Pali Rohár
2016-03-08 11:20                         ` Darren Hart
2015-12-04 12:55       ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień
2015-12-04 16:04         ` Andy Lutomirski
2015-12-04  8:48     ` Pali Rohár
2015-12-04 12:36       ` Michał Kępień

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201511292050.18883@pali \
    --to=pali.rohar@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=kernel@kempniu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox