From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbbK3HOP (ORCPT ); Mon, 30 Nov 2015 02:14:15 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:47353 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468AbbK3HON (ORCPT ); Mon, 30 Nov 2015 02:14:13 -0500 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.204 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Mon, 30 Nov 2015 16:14:28 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Message-ID: <20151130071428.GC3262@bbox> References: <1448598194-24754-1-git-send-email-sergey.senozhatsky@gmail.com> <1448598194-24754-3-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 In-Reply-To: <1448598194-24754-3-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/11/30 16:14:10, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2015/11/30 16:14:10, Serialize complete at 2015/11/30 16:14:10 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2015 at 01:23:14PM +0900, Sergey Senozhatsky wrote: > Do not __GFP_ZERO allocated zcomp ->private pages. We keep > allocated streams around and use them for read/write requests, > so we supply a zeroed out ->private to compression algorithm > as a scratch buffer only once -- the first time we use that > stream. For the rest of IO requests served by this stream > ->private usually contains some temporarily data from the > previous requests. > > Signed-off-by: Sergey Senozhatsky Acked-by: Minchan Kim Thanks.