From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753746AbbK3QR1 (ORCPT ); Mon, 30 Nov 2015 11:17:27 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55078 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbbK3QRZ (ORCPT ); Mon, 30 Nov 2015 11:17:25 -0500 Date: Mon, 30 Nov 2015 16:17:05 +0000 From: Mark Brown To: Maxime Ripard Cc: Liam Girdwood , Chen-Yu Tsai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20151130161705.GY1929@sirena.org.uk> References: <1448897867-22320-1-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R9qb+eAX/AZDW6n0" Content-Disposition: inline In-Reply-To: <1448897867-22320-1-git-send-email-maxime.ripard@free-electrons.com> X-Cookie: A beer delayed is a beer denied. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: sun4i: Implement MIC1 capture X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --R9qb+eAX/AZDW6n0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote: A couple of minor issues below but I'll apply this - please send followup patches. > +static void sun4i_codec_start_capture(struct sun4i_codec *scodec) > +{ > + /* > + * FIXME: according to the BSP, we might need to drive a PA > + * GPIO high here on some boards > + */ That's not something this driver needs to worry about, that's something the machine driver will do - the whole purpose is to glue all the different components on the board together. > + if (clk_set_rate(scodec->clk_module, clk_freq)) > + return -EINVAL; It'd be better to pass back the error code from clk_set_rate(). --R9qb+eAX/AZDW6n0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWXHaAAAoJECTWi3JdVIfQ4IoH/3FGtbGtlQ3XEUwRxe61wXmf yd3ixVGfLkyKAjdcTbM0j1sVKW2V/GaEwtAG5SuM61AhM2p5354iCsop0oHBxbr+ 8XlfqmvYAr7p1QZ0De+CCjR0SBmDIWPgY7DqJgyRAofjJyN2qRum3HA3yZdsbCzJ RhXaKB52F7IFL7rshspPdoGjugw8lKDwaVeLJ04F93I7RbCXRdx9S4ebggtLp4Yv kTxzSrx+IEyEHvi992XaCmIRu51QHoj22EYNkS+axK0QHFSRKjvchKaUpdbZLpoZ NIOTc/dIpunXmPMNe9WyB/1jJJ5iQKsw5ErlTZRNMV1ffzCQUyDTuWFrOnpfSlA= =makr -----END PGP SIGNATURE----- --R9qb+eAX/AZDW6n0--