From: Mark Brown <broonie@kernel.org>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: fix a possible NULL dereference
Date: Mon, 30 Nov 2015 16:38:56 +0000 [thread overview]
Message-ID: <20151130163856.GC1929@sirena.org.uk> (raw)
In-Reply-To: <20151126071715.GB28184@Red>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
On Thu, Nov 26, 2015 at 08:17:15AM +0100, LABBE Corentin wrote:
> On Wed, Nov 25, 2015 at 11:46:45PM +0000, Kuninori Morimoto wrote:
> > > + of_data = of_device_get_match_data(dev);
> > > + if (!of_data)
> > > + return 1;
> > return 1 ?
> > You want to use -EINVAL ?
> I do that Uwe Kleine-König said to me to do in others thread:
> https://lkml.org/lkml/2015/11/12/70 and https://lkml.org/lkml/2015/11/16/211
What error code to return is going to depend on the context - you need
to look at what the caller is expecting and how it will handle the value
returned.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-11-30 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 12:49 [PATCH] ASoC: rsnd: fix a possible NULL dereference LABBE Corentin
2015-11-25 23:46 ` Kuninori Morimoto
2015-11-26 7:17 ` LABBE Corentin
2015-11-30 16:38 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130163856.GC1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=clabbe.montjoie@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox