From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Move sched_to_prio arrays out of line
Date: Mon, 30 Nov 2015 09:16:30 -0800 [thread overview]
Message-ID: <20151130171630.GB3528@tassilo.jf.intel.com> (raw)
In-Reply-To: <20151130090313.GE17308@twins.programming.kicks-ass.net>
On Mon, Nov 30, 2015 at 10:03:13AM +0100, Peter Zijlstra wrote:
> On Sun, Nov 29, 2015 at 08:59:43PM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > When building a kernel with a gcc 6 snapshot the compiler complains
> > about unused const static variables for prio_to_weight and prio_to_mult
> > for multiple scheduler files (all but core.c and autogroup.c)
> >
> > The way the array is currently declared it will be duplicated in
> > every scheduler file that includes sched.h, which seems rather wasteful.
>
> Yeah, that's not right.
>
> > Move the array out of line into core.c. I also added a sched_ prefix
> > to avoid any potential name space collisions.
>
> Thanks!
Thanks. Please make sure the merge v2, v1 had one missing conversion.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2015-11-30 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 4:59 [PATCH] sched: Move sched_to_prio arrays out of line Andi Kleen
2015-11-30 9:03 ` Peter Zijlstra
2015-11-30 17:16 ` Andi Kleen [this message]
2015-12-04 11:57 ` [tip:sched/core] sched/core: Move the sched_to_prio[] " tip-bot for Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2015-11-30 4:48 [PATCH] sched: Move sched_to_prio " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130171630.GB3528@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox