From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753956AbbK3Qqf (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Nov 2015 11:46:35 -0500
Received: from mail-out.m-online.net ([212.18.0.9]:60833 "EHLO
	mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752473AbbK3Qqd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Nov 2015 11:46:33 -0500
X-Auth-Info: aGL+U4pdXQ5Ztm7/D9QjrJ/CE9L+bTkmwe8hqIGbbe4=
From: Marek Vasut <marex@denx.de>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: Re: [PATCH] spi/nor: Fix error message with unrecognized JEDEC
Date: Mon, 30 Nov 2015 17:46:29 +0100
User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; )
Cc: David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>,
        Huang Shijie <shijie.huang@intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Gabor Juhos <juhosg@openwrt.org>,
        "Bean Huo =?utf-8?q?=E9=9C=8D=E6=96=8C=E6=96=8C?= (beanhuo)" 
	<beanhuo@micron.com>,
        Furquan Shaikh <furquan@google.com>, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <1448897111-30713-1-git-send-email-ricardo.ribalda@gmail.com>
In-Reply-To: <1448897111-30713-1-git-send-email-ricardo.ribalda@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201511301746.29684.marex@denx.de>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
> The error message was:
> 
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00,  0,  0
> 
> The new error message:
> 
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..7d2b96d5f350 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
> spi_nor *nor) return &spi_nor_ids[tmp];
>  		}
>  	}
> -	dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> +	dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",

You can change it to %02x to make it consistent, no ? What do you think ?

>  		id[0], id[1], id[2]);
>  	return ERR_PTR(-ENODEV);
>  }

Best regards,
Marek Vasut