From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Sasha Levin <sasha.levin@oracle.com>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: CPU: 12 PID: 16862 at ./arch/x86/include/asm/thread_info.h:236
Date: Mon, 30 Nov 2015 19:48:04 +0100 [thread overview]
Message-ID: <20151130184804.GA7455@redhat.com> (raw)
In-Reply-To: <20151130165244.GA3816@twins.programming.kicks-ass.net>
On 11/30, Peter Zijlstra wrote:
>
> On Mon, Nov 30, 2015 at 04:44:05PM +0000, Al Viro wrote:
> > On Mon, Nov 30, 2015 at 11:20:44AM -0500, Sasha Levin wrote:
> > > Hi all,
> > >
> > > I've hit the following while fuzzing with trinity on the latest -next kernel:
> >
> > __set_current_state(TASK_INTERRUPTIBLE);
> > schedule();
> > set_restore_sigmask();
> >
> > somehow got out of schedule() without TIF_SIGPENDING being set...
>
> A random wakeup (which are always possible) can make that happen, right?
Yes, sigsuspend() should do "while (!signal_pending(current))". Like
sys_pause() does, -ERESTARTNOHAND without signal_pending() is equally
wrong.
I'll send the fix unless Sasha wants to do this.
> I'm (as always) a little vague on signals, but who is responsible for
> setting that bit?
See above, TS_RESTORE_SIGMASK doesn't differ from -ERESTART* in that
you can only use it if signal_pending() is true.
Oleg.
next prev parent reply other threads:[~2015-11-30 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 16:20 WARNING: CPU: 12 PID: 16862 at ./arch/x86/include/asm/thread_info.h:236 Sasha Levin
2015-11-30 16:44 ` Al Viro
2015-11-30 16:52 ` Peter Zijlstra
2015-11-30 18:48 ` Oleg Nesterov [this message]
2016-01-09 7:08 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130184804.GA7455@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox