* [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()
@ 2015-11-13 20:21 Nizam Haider
2015-11-15 10:57 ` Hans Ulli Kroll
2015-11-30 19:04 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Nizam Haider @ 2015-11-13 20:21 UTC (permalink / raw)
To: ulli.kroll
Cc: a.zummo, alexandre.belloni, linux-arm-kernel, rtc-linux,
linux-kernel, Nizam Haider, Nizam Haider
The driver core clears the driver data to NULL after device_release
or on probe failure
Signed-off-by: Nizam Haider <nijamh@cdac.in>
---
drivers/rtc/rtc-gemini.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
index e841846..f46b6d4 100644
--- a/drivers/rtc/rtc-gemini.c
+++ b/drivers/rtc/rtc-gemini.c
@@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
struct gemini_rtc *rtc = platform_get_drvdata(pdev);
rtc_device_unregister(rtc->rtc_dev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()
2015-11-13 20:21 [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata() Nizam Haider
@ 2015-11-15 10:57 ` Hans Ulli Kroll
2015-11-30 19:04 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Hans Ulli Kroll @ 2015-11-15 10:57 UTC (permalink / raw)
To: Nizam Haider
Cc: ulli.kroll, a.zummo, alexandre.belloni, linux-arm-kernel,
rtc-linux, linux-kernel, Nizam Haider
On Sat, 14 Nov 2015, Nizam Haider wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure
>
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> ---
> drivers/rtc/rtc-gemini.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c
> index e841846..f46b6d4 100644
> --- a/drivers/rtc/rtc-gemini.c
> +++ b/drivers/rtc/rtc-gemini.c
> @@ -156,7 +156,6 @@ static int gemini_rtc_remove(struct platform_device *pdev)
> struct gemini_rtc *rtc = platform_get_drvdata(pdev);
>
> rtc_device_unregister(rtc->rtc_dev);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.8.1.4
>
>
Acked-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata()
2015-11-13 20:21 [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata() Nizam Haider
2015-11-15 10:57 ` Hans Ulli Kroll
@ 2015-11-30 19:04 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2015-11-30 19:04 UTC (permalink / raw)
To: Nizam Haider
Cc: ulli.kroll, a.zummo, linux-arm-kernel, rtc-linux, linux-kernel,
Nizam Haider
On 14/11/2015 at 01:51:29 +0530, Nizam Haider wrote :
> The driver core clears the driver data to NULL after device_release
> or on probe failure
>
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> ---
> drivers/rtc/rtc-gemini.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-30 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-13 20:21 [PATCH] Rtc: rtc-gemini.c: Remove unnecessary platform_set_drvdata() Nizam Haider
2015-11-15 10:57 ` Hans Ulli Kroll
2015-11-30 19:04 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox