* [PATCH] clk: qoriq: fix memory leak
@ 2015-11-23 10:06 Sudip Mukherjee
2015-11-30 22:40 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2015-11-23 10:06 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd; +Cc: linux-kernel, linux-clk, Sudip Mukherjee
If get_pll_div() fails we exited by returning NULL but we missed
releasing hwc.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/clk/clk-qoriq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 1ab0fb8..7bc1c45 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -778,8 +778,10 @@ static struct clk * __init create_one_cmux(struct clockgen *cg, int idx)
*/
clksel = (cg_in(cg, hwc->reg) & CLKSEL_MASK) >> CLKSEL_SHIFT;
div = get_pll_div(cg, hwc, clksel);
- if (!div)
+ if (!div) {
+ kfree(hwc);
return NULL;
+ }
pct80_rate = clk_get_rate(div->clk);
pct80_rate *= 8;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: qoriq: fix memory leak
2015-11-23 10:06 [PATCH] clk: qoriq: fix memory leak Sudip Mukherjee
@ 2015-11-30 22:40 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2015-11-30 22:40 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Michael Turquette, linux-kernel, linux-clk
On 11/23, Sudip Mukherjee wrote:
> If get_pll_div() fails we exited by returning NULL but we missed
> releasing hwc.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
Applied to clk-fixes
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-30 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-23 10:06 [PATCH] clk: qoriq: fix memory leak Sudip Mukherjee
2015-11-30 22:40 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).