From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: isdn@linux-pingi.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] isdn: remove spellcaster driver
Date: Tue, 01 Dec 2015 16:07:09 -0500 (EST) [thread overview]
Message-ID: <20151201.160709.566323664243976564.davem@davemloft.net> (raw)
In-Reply-To: <2948626.r4RdgunA3R@wuerfel>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 30 Nov 2015 11:34:09 +0100
> The 'sc' ISDN driver relies on using readl() to access ISA I/O memory.
> This has been deprecated and produced warnings since linux-2.3.23,
> disabled by default since 2.4.10 and finally removed in 2.6.5.
>
> I found this because the compiling the driver for ARM produces
> a warning:
>
> In file included from ../drivers/isdn/sc/includes.h:8:0,
> from ../drivers/isdn/sc/init.c:13:
> ../arch/arm/include/asm/io.h:115:21: note: expected 'const volatile void *' but argument is of type 'long unsigned int'
>
> It is pretty clear that this driver has not been used for a long time
> and there is no point fixing it now, so let's remove it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> There has been some discussion about removing all the ISA based ISDN
> drivers in the past. I'm not trying to restart that discussion at the
> moment, and I did not find the same bug in the other drivers, so
> let's just remove this one for now.
Applied to net-next, we can resurrect+fix this driver if someone actually
uses it.
Thanks Arnd.
prev parent reply other threads:[~2015-12-01 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 10:34 [PATCH] isdn: remove spellcaster driver Arnd Bergmann
2015-11-30 13:39 ` isdn
2015-12-01 21:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201.160709.566323664243976564.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox