From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473AbbLAAnm (ORCPT ); Mon, 30 Nov 2015 19:43:42 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36361 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754314AbbLAAnk (ORCPT ); Mon, 30 Nov 2015 19:43:40 -0500 Date: Tue, 1 Dec 2015 09:44:41 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Sergey Senozhatsky , Minchan Kim , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Message-ID: <20151201004441.GB653@swordfish> References: <1448598194-24754-1-git-send-email-sergey.senozhatsky@gmail.com> <1448598194-24754-2-git-send-email-sergey.senozhatsky@gmail.com> <20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151130161004.171a80a7f618a2c55ff885c6@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (11/30/15 16:10), Andrew Morton wrote: > > From: Minchan Kim > > > > Each zcomp backend uses own gfp flag but it's pointless > > because the context they could be called is driven by upper > > layer(ie, zcomp frontend). As well, zcomp frondend could > > call them in different context. One context(ie, zram init part) > > is it should be better to make sure successful allocation > > other context(ie, further stream allocation part for accelarating > > I/O speed) is just optional so let's pass gfp down from driver > > (ie, zcomp frontend) like normal MM convention. > > > > [sergey: add missing __vmalloc zero and highmem gfps] > > Signed-off-by: Minchan Kim > > Acked-by: Sergey Senozhatsky > > I changed this to signed-off-by:you. Documentation/SubmittingPatches > section 11 explains why ;) Thank you. > (Hm, rule (c) is recursive. Nice!) -ss