Re: [PATCH v2 2/4] introduce post-init read-only memory

Kees Cook
2015-12-09T19:35:14Z

On Mon, Nov 30, 2015 at 2:24 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 11/25/15 16:15, PaX Team wrote:
>> On 25 Nov 2015 at 15:31, Kees Cook wrote:
>>
>>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>>> index c4bd0e2c173c..772c784ba763 100644
>>> --- a/include/asm-generic/vmlinux.lds.h
>>> +++ b/include/asm-generic/vmlinux.lds.h
>>> @@ -256,6 +256,7 @@
>>> .rodata : AT(ADDR(.rodata) - LOAD_OFFSET) { \
>>> VMLINUX_SYMBOL(__start_rodata) = .; \
>>> *(.rodata) *(.rodata.*) \
>>> + *(.data..ro_after_init) /* Read only after init */ \
>> ^^^^^^^^^^^
>> looks like it's tabs vs. spaces...

Not sure what caused that, but I see it as tabs in my tree.

> One more thing... double dots I think has special meanings to gcc, so it
> might be better to avoid.

Hrm, I could find no information about this, so I've left it as-is.

-Kees

--
Kees Cook
Chrome OS & Brillo Security