From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
Kyeongdon Kim <kyeongdon.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()
Date: Tue, 1 Dec 2015 16:33:11 +0900 [thread overview]
Message-ID: <20151201073311.GD894@swordfish> (raw)
In-Reply-To: <20151201071542.GB894@swordfish>
On (12/01/15 16:15), Sergey Senozhatsky wrote:
> On (12/01/15 15:35), Kyeongdon Kim wrote:
> [..]
> > @test #4
> > kmalloc(f)
> > __vmalloc(f)
> > // cannot find failure both until now
> >
> > log message (test #4) :
> > <4>[ 641.440468][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002190000
> > <snip>
> > <4>[ 922.182980][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002208000
> > <snip>
> > <4>[ 923.197593][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002020000
> > <snip>
> > <4>[ 939.813499][7] KDKIM: zcomp_lz4_create: 24: ret = ffffffc0020a0000
>
> Thanks!
>
> > So,is there another problem if we remove the flag from both sides?
> >
>
> Technically, '~__GFP_NOMEMALLOC' is what we've been doing for some time (well,
> always); and, as Minchan noted, zsmalloc does not depend on emergency pools.
>
> I vote for removal of __GFP_NOMEMALLOC from both kmalloc() and __vmalloc().
>
um.. which is very close to
"remove vmalloc() fallback and use kzalloc(f & ~__GFP_NOMEMALLOC) only"
-ss
next prev parent reply other threads:[~2015-12-01 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:10 [PATCH v3 0/2] zram/zcomp: stream allocation fixes and tweaks Sergey Senozhatsky
2015-11-27 4:10 ` [PATCH v3 1/2] zram/zcomp: use GFP_NOIO to allocate streams Sergey Senozhatsky
2015-11-30 7:09 ` Minchan Kim
2015-11-27 4:10 ` [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky
2015-11-30 7:10 ` Minchan Kim
2015-11-30 10:42 ` kyeongdon.kim
2015-11-30 11:14 ` Sergey Senozhatsky
2015-12-01 2:04 ` kyeongdon.kim
[not found] ` <20151130231841.GA960@bbox>
2015-12-01 0:33 ` Sergey Senozhatsky
2015-12-01 2:31 ` Re: " kyeongdon.kim
2015-12-01 4:44 ` Minchan Kim
[not found] ` <20151201045535.GA5999@bbox>
2015-12-01 5:16 ` Sergey Senozhatsky
2015-12-01 6:35 ` Kyeongdon Kim
2015-12-01 7:15 ` Sergey Senozhatsky
2015-12-01 7:33 ` Sergey Senozhatsky [this message]
2015-12-01 8:16 ` Minchan Kim
2015-12-01 9:11 ` Sergey Senozhatsky
2015-12-01 7:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201073311.GD894@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox