From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Vishnu Patekar <vishnupatekar0510@gmail.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Emilio Lopez <emilio@elopez.com.ar>,
Linus Walleij <linus.walleij@linaro.org>,
Jens Kuske <jenskuske@gmail.com>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi
Date: Tue, 1 Dec 2015 09:59:40 +0100 [thread overview]
Message-ID: <20151201085940.GC29263@lukather> (raw)
In-Reply-To: <CAEzqOZsiwbaKwH4J5CjaHoX6rdgj6kq3opvBUXiGJRfum_Se8Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4231 bytes --]
Hi!
On Mon, Nov 30, 2015 at 02:09:14AM +0800, Vishnu Patekar wrote:
> >> + reg = <0x01c20800 0x400>;
> >> + clocks = <&osc24M>;
> >> + gpio-controller;
> >> + interrupt-controller;
> >> + #interrupt-cells = <3>;
> >> + #gpio-cells = <3>;
> >> +
> >> + i2c0_pins_a: i2c0@0 {
> >> + allwinner,pins = "PH0", "PH1";
> >> + allwinner,function = "i2c0";
> >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + i2c1_pins_a: i2c1@0 {
> >> + allwinner,pins = "PH2", "PH3";
> >> + allwinner,function = "i2c1";
> >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + i2c2_pins_a: i2c2@0 {
> >> + allwinner,pins = "PH4", "PH5";
> >> + allwinner,function = "i2c2";
> >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + mmc0_pins_a: mmc0@0 {
> >> + allwinner,pins = "PF0", "PF1", "PF2",
> >> + "PF3", "PF4", "PF5";
> >> + allwinner,function = "mmc0";
> >> + allwinner,drive = <SUN4I_PINCTRL_30_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + mmc1_pins_a: mmc1@0 {
> >> + allwinner,pins = "PG0", "PG1", "PG2",
> >> + "PG3", "PG4", "PG5";
> >> + allwinner,function = "mmc1";
> >> + allwinner,drive = <SUN4I_PINCTRL_30_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + mmc2_8bit_pins: mmc2_8bit {
> >> + allwinner,pins = "PC5", "PC6", "PC8",
> >> + "PC9", "PC10", "PC11",
> >> + "PC12", "PC13", "PC14",
> >> + "PC15";
> >> + allwinner,function = "mmc2";
> >> + allwinner,drive = <SUN4I_PINCTRL_30_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + uart0_pins_a: uart0@0 {
> >> + allwinner,pins = "PF2", "PF4";
> >> + allwinner,function = "uart0";
> >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >> +
> >> + uart0_pins_b: uart0@1 {
> >> + allwinner,pins = "PB9", "PB10";
> >> + allwinner,function = "uart0";
> >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> >> + };
> >
> > Are you going to use all these options?
>
> Not, only uart0_pins_a and uart0_pins_b and mmc0_pins_a will be used for now.
> As, these are not enabled, I don't see any harm in keeping those here.
It bloats the DT for no particular reason.
> Let me know in case you want to remove, I'll do it.
Yes, please.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-12-01 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 23:46 [PATCH v2 0/3] Add basic support for Allwinner A83T SOC Vishnu Patekar
2015-10-22 23:46 ` [PATCH v2 1/3] ARM: sunxi: Introduce Allwinner for A83T support Vishnu Patekar
2015-10-23 1:37 ` Chen-Yu Tsai
2015-11-29 12:02 ` Vishnu Patekar
2015-10-22 23:46 ` [PATCH v2 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Vishnu Patekar
2015-10-25 20:20 ` Maxime Ripard
2015-11-29 18:09 ` Vishnu Patekar
2015-12-01 8:59 ` Maxime Ripard [this message]
2015-10-26 2:21 ` Chen-Yu Tsai
2015-10-22 23:46 ` [PATCH v2 3/3] ARM: dts: sun8i: Add A83T HomletV2 Board by Allwinner Vishnu Patekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201085940.GC29263@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=galak@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jenskuske@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox