Re: [PATCH] ASoC: sun4i: Implement MIC1 capture

Maxime Ripard
2015-12-01T09:14:09Z

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

Hi,

On Mon, Nov 30, 2015 at 04:17:05PM +0000, Mark Brown wrote:
> On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote:
>
> A couple of minor issues below but I'll apply this - please send
> followup patches.
>
> > +static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
> > +{
> > + /*
> > + * FIXME: according to the BSP, we might need to drive a PA
> > + * GPIO high here on some boards
> > + */
>
> That's not something this driver needs to worry about, that's something
> the machine driver will do - the whole purpose is to glue all the
> different components on the board together.

Indeed, I'll remove the comment.

>
> > + if (clk_set_rate(scodec->clk_module, clk_freq))
> > + return -EINVAL;
>
> It'd be better to pass back the error code from clk_set_rate().

Ack, I'll send a patch.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]