Re: [PATCH] staging: unisys: use common return path

Sudip Mukherjee
2015-12-02T05:02:56Z

On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> >
> > Why is it okay here? I don't understand why this function would be
> > any different than the other places where the code used a goto.
>
> What I meant was that I'm generally opposed to "common exit paths".
> Mixing all the exit paths together often makes the code more complicated
> and leads to errors. That makes sense from a common sense perspective

By "common exit path" do you mean mixing up of success and error paths?

regards
sudip