From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Wilck, Martin" <martin.wilck@ts.fujitsu.com>
Cc: "Jarkko Sakkinen" <jarkko.sakkinen@linux.intel.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"'Uwe Kleine-König'" <u.kleine-koenig@pengutronix.de>
Subject: Re: [tpmdd-devel] [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter
Date: Tue, 1 Dec 2015 10:39:40 -0700 [thread overview]
Message-ID: <20151201173940.GC691@obsidianresearch.com> (raw)
In-Reply-To: <C5A28EF7B98F574C85C70238C8E9ECC04E682BF14F@ABGEX74E.FSC.NET>
On Tue, Dec 01, 2015 at 12:50:28PM +0100, Wilck, Martin wrote:
> The patch introduces one user-visible change, because now the ACPI and
> PnP drivers are registered even with "force=1". This causes my TPM to be
> show up twice in sysfs:
Registering all the drivers is deliberate, IMHO, force should not be
used if the driver binds normally.
However, getting two is a bug, and it is because tpm_tis is not doing
resource management.
I'll add another patch to fix that..
Also, I'll change the order of the driver registers so that the
platform driver goes first, that way if force is used the platform
driver will bind and still auto probe irqs and then the other drivers
will bounce off the claimed resource.
Jason
prev parent reply other threads:[~2015-12-01 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 19:27 tpm_tis: Clean up force module parameter Jason Gunthorpe
2015-11-30 19:27 ` [PATCH 1/2] tpm_tis: Disable interrupt auto probing on a per-device basis Jason Gunthorpe
2015-12-01 7:17 ` Uwe Kleine-König
2015-12-01 17:26 ` Jason Gunthorpe
2015-11-30 19:27 ` [PATCH 2/2] tpm_tis: Clean up the force=1 module parameter Jason Gunthorpe
2015-12-01 7:28 ` Uwe Kleine-König
2015-12-01 8:35 ` Jarkko Sakkinen
2015-12-01 17:43 ` Jason Gunthorpe
2015-12-01 20:51 ` Jarkko Sakkinen
2015-12-01 17:35 ` Jason Gunthorpe
2015-12-01 11:50 ` [tpmdd-devel] " Wilck, Martin
2015-12-01 17:39 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201173940.GC691@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox