* [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC
@ 2015-11-30 19:41 Ricardo Ribalda Delgado
2015-11-30 22:37 ` Rafał Miłecki
2015-12-01 18:40 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-11-30 19:41 UTC (permalink / raw)
To: David Woodhouse, Brian Norris, Rafał Miłecki,
Huang Shijie, Mika Westerberg, Marek Vasut, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
Cc: Ricardo Ribalda Delgado
The error message was:
m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
The new error message:
m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
v2: Changes by Marek Vasut
Use %02 instead of %.2
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index b7c038c75684..f8a9b77aac76 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
return &spi_nor_ids[tmp];
}
}
- dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
+ dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
id[0], id[1], id[2]);
return ERR_PTR(-ENODEV);
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC
2015-11-30 19:41 [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado
@ 2015-11-30 22:37 ` Rafał Miłecki
2015-12-01 18:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2015-11-30 22:37 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: David Woodhouse, Brian Norris, Huang Shijie, Mika Westerberg,
Marek Vasut, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
On 30 November 2015 at 20:41, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>
> v2: Changes by Marek Vasut
>
> Use %02 instead of %.2
>
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..f8a9b77aac76 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct spi_nor *nor)
> return &spi_nor_ids[tmp];
> }
> }
> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %02x, %02x\n",
Looks fine :)
--
Rafał
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC
2015-11-30 19:41 [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado
2015-11-30 22:37 ` Rafał Miłecki
@ 2015-12-01 18:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-12-01 18:40 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: David Woodhouse, Rafał Miłecki, Huang Shijie,
Mika Westerberg, Marek Vasut, Gabor Juhos,
Bean Huo 霍斌斌 (beanhuo), Furquan Shaikh,
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
On Mon, Nov 30, 2015 at 08:41:17PM +0100, Ricardo Ribalda Delgado wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>
> v2: Changes by Marek Vasut
Pushed to l2-mtd.git
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-30 19:41 [PATCH v2] spi/nor: Fix error message with unrecognized JEDEC Ricardo Ribalda Delgado
2015-11-30 22:37 ` Rafał Miłecki
2015-12-01 18:40 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox