From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757475AbbLBB4g (ORCPT ); Tue, 1 Dec 2015 20:56:36 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:23948 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755682AbbLBB4f (ORCPT ); Tue, 1 Dec 2015 20:56:35 -0500 Date: Tue, 1 Dec 2015 20:56:24 -0500 From: Steven Rostedt To: Andi Kleen Cc: x86@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/4] tracepoints: Move struct tracepoint to new tracepoint-defs.h header Message-ID: <20151201205624.1a33124f@grimm.local.home> In-Reply-To: <1449018060-1742-2-git-send-email-andi@firstfloor.org> References: <1449018060-1742-1-git-send-email-andi@firstfloor.org> <1449018060-1742-2-git-send-email-andi@firstfloor.org> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Dec 2015 17:00:58 -0800 Andi Kleen wrote: > From: Andi Kleen > > Steven recommended open coding access to tracepoint->key to add > trace points to headers. Unfortunately this is difficult for some > headers (such as x86 asm/msr.h) because including tracepoint.h > includes so many other headers that it causes include loops. > The main problem is the include of linux/rcupdate.h, which > pulls in a lot of other headers. The rcu header is only needed > when actually defining trace points. > > Move the struct tracepoint into a separate tracepoint-defs.h > header that can be included without pulling in all of RCU. > > Signed-off-by: Andi Kleen Acked-by: Steven Rostedt -- Steve