Re: [PATCH 1/2] regulator: Add coupled regulator

Javier Martinez Canillas
2015-11-30T19:06:17Z

Hello Maxime,

On Mon, Nov 30, 2015 at 12:29 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:

[snip]

>
> +config REGULATOR_COUPLED_VOLTAGE

Shouldn't this depend on OF?

> + tristate "Coupled voltage regulator support"

the Kconfig symbol is tristate so the driver can be built as a module...

> +
> +static struct of_device_id coupled_regulator_of_match[] = {
> + { .compatible = "coupled-voltage-regulator" },
> + { /* Sentinel */ },
> +};
> +

...but the driver is missing a MODULE_DEVICE_TABLE(of, ...) so module
autoloading won't work.

Best regards,
Javier