From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ben Romer <benjamin.romer@unisys.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
sparmaintainer@unisys.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: unisys: use common return path
Date: Wed, 2 Dec 2015 10:32:49 +0530 [thread overview]
Message-ID: <20151202050248.GC3692@sudip-pc> (raw)
In-Reply-To: <20151201155724.GG18797@mwanda>
On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> >
> > Why is it okay here? I don't understand why this function would be
> > any different than the other places where the code used a goto.
>
> What I meant was that I'm generally opposed to "common exit paths".
> Mixing all the exit paths together often makes the code more complicated
> and leads to errors. That makes sense from a common sense perspective
By "common exit path" do you mean mixing up of success and error paths?
regards
sudip
next prev parent reply other threads:[~2015-12-02 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 6:15 [PATCH] staging: unisys: use common return path Sudip Mukherjee
2015-12-01 8:00 ` Dan Carpenter
2015-12-01 8:06 ` Dan Carpenter
2015-12-01 9:57 ` Sudip Mukherjee
2015-12-01 16:05 ` Dan Carpenter
2015-12-02 4:49 ` Sudip Mukherjee
2015-12-01 14:54 ` Ben Romer
2015-12-01 15:57 ` Dan Carpenter
2015-12-01 16:16 ` Ben Romer
2015-12-02 5:01 ` Sudip Mukherjee
2015-12-02 5:02 ` Sudip Mukherjee [this message]
2015-12-02 6:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202050248.GC3692@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=benjamin.romer@unisys.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox