From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbbLBGU4 (ORCPT ); Wed, 2 Dec 2015 01:20:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28004 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbbLBGUz (ORCPT ); Wed, 2 Dec 2015 01:20:55 -0500 Date: Wed, 2 Dec 2015 09:20:48 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Ben Romer , devel@driverdev.osuosl.org, Greg Kroah-Hartman , sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: unisys: use common return path Message-ID: <20151202062048.GK7289@mwanda> References: <1448950555-8846-1-git-send-email-sudipm.mukherjee@gmail.com> <20151201080045.GE18797@mwanda> <565DB4BA.80208@unisys.com> <20151201155724.GG18797@mwanda> <20151202050248.GC3692@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151202050248.GC3692@sudip-pc> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2015 at 10:32:49AM +0530, Sudip Mukherjee wrote: > By "common exit path" do you mean mixing up of success and error paths? Normally it's just the error paths which are mixed together. Back in the day, this unisys driver had tons of error handling bugs so that I didn't even bother reporting them all. http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/068932.html http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/069073.html regards, dan carpenter