From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758455AbbLBOYw (ORCPT ); Wed, 2 Dec 2015 09:24:52 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47186 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757303AbbLBOYv (ORCPT ); Wed, 2 Dec 2015 09:24:51 -0500 Date: Wed, 2 Dec 2015 15:24:45 +0100 From: Pavel Machek To: Alexander Kapshuk Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, jim.epost@gmail.com, richard@nod.at, tytso@mit.edu Subject: Re: [PATCH 01/22] ver_linux: gcc -dumpversion, use regex to find version number Message-ID: <20151202072725.GA26580@amd> References: <1444675202-1375-1-git-send-email-alexander.kapshuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444675202-1375-1-git-send-email-alexander.kapshuk@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2015-10-12 21:39:41, Alexander Kapshuk wrote: > Rely on regex to find the version number, rather than a field number. Are you sure that is good idea? I'd say that the field number is going to fail in more obvious way, which is a good thing. Pavel > Signed-off-by: Alexander Kapshuk > --- > scripts/ver_linux | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/scripts/ver_linux b/scripts/ver_linux > index 7de36df..af6467e 100755 > --- a/scripts/ver_linux > +++ b/scripts/ver_linux > @@ -11,8 +11,12 @@ echo ' ' > uname -a > echo ' ' > > -gcc -dumpversion 2>&1| awk \ > -'NR==1{print "Gnu C ", $1}' > +gcc -dumpversion 2>&1 | > +awk '/[0-9]+([.]?[0-9]+)+/ && !/not found$/{ > + match($0, /[0-9]+([.]?[0-9]+)+/) > + printf("GNU C\t\t\t%s\n", > + substr($0,RSTART,RLENGTH)) > +}' > > make --version 2>&1 | awk -F, '{print $1}' | awk \ > '/GNU Make/{print "Gnu make ",$NF}' -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html