Re: [PATCH 01/22] ver_linux: gcc -dumpversion, use regex to find version number

Jim Davis
2015-10-14T21:43:41Z

On Wed, Oct 14, 2015 at 2:29 AM, Alexander Kapshuk
<alexander.kapshuk@gmail.com> wrote:
> On Wed, Oct 14, 2015 at 2:21 AM, Jim Davis <jim.epost@gmail.com> wrote:
>> I tried out patches 1-22 on a Fedora 22 system with the v4.3-rc5
>> source tree; everything looks pretty good. The old ver_linux script
>> didn't get the mount version right, but the new one does
>>
>> < mount debug
>>> Mount 2.26.2
>>
>> One minor thing with Net-tools, the old version printed
>>
>> < Net-tools 2.10-alpha
>>
>> while the regex the in the new version skips the '-alpha'
>>
>>> Net-tools 2.10
>>
>> Though I'm not a big fan of patch 22 (the sed hold space thing) there
>> are several nice improvements all in all.
>>
>> --
>> Jim
>
> Thanks very much for reviewing the patches and for your commentary.

You're welcome, but I think you may need to run checkpatch -- from a
quick test there were a few minor whitespace issues.

--
Jim