From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932803AbbLBL20 (ORCPT ); Wed, 2 Dec 2015 06:28:26 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:51743 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932222AbbLBL2W (ORCPT ); Wed, 2 Dec 2015 06:28:22 -0500 Date: Wed, 2 Dec 2015 14:27:33 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Amir Shehata , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH 14/40] staging: lustre: fix crash due to NULL networks string Message-ID: <20151202112733.GN18797@mwanda> References: <1448062576-23757-1-git-send-email-jsimmons@infradead.org> <1448062576-23757-15-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448062576-23757-15-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This feels like we are fixing a bug introduce in PATCH 11 when we removed a NULL check. Don't introduce bugs and then fix them in the same patchset; the fix has to be folded into the original patch. regards, dan carpenter