From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758019AbbLBNA0 (ORCPT ); Wed, 2 Dec 2015 08:00:26 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:34643 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756465AbbLBNAZ (ORCPT ); Wed, 2 Dec 2015 08:00:25 -0500 Date: Wed, 2 Dec 2015 15:59:45 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , Amir Shehata , Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH 21/40] staging: lustre: improve LNet clean up code and API Message-ID: <20151202125440.GS18797@mwanda> References: <1448062576-23757-1-git-send-email-jsimmons@infradead.org> <1448062576-23757-22-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448062576-23757-22-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually we're going to have to redo so much code that it's not worth it for me to review the rest of these patches. Please just look over everything again: BAD: return -1; GOOD: return -EINVAL; BAD: failed0: GOOD: free_something: BAD: if (rc != 0) GOOD: if (rc) Do one thing per patch. Do not introduce a bug and then fix it in a later patch. Check ioc_len more carefully. Don't make the code look ugly just to please checkpatch.pl. Do error handling not success handling. Try to avoid indenting a far to the right. regards, dan carpenter