From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759066AbbLBQzn (ORCPT ); Wed, 2 Dec 2015 11:55:43 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37135 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759049AbbLBQzj (ORCPT ); Wed, 2 Dec 2015 11:55:39 -0500 Date: Wed, 2 Dec 2015 17:55:36 +0100 From: Thierry Reding To: Mark Yao Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 7/9] drm/rockchip: force enable vop when do mode setting Message-ID: <20151202165536.GA14019@ulmo> References: <1448940391-23333-1-git-send-email-mark.yao@rock-chips.com> <1448940721-23488-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Content-Disposition: inline In-Reply-To: <1448940721-23488-1-git-send-email-mark.yao@rock-chips.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 01, 2015 at 11:32:01AM +0800, Mark Yao wrote: > When do mode setting, mean that we want to enable display output, > but sometimes, vop_crtc_enable is after mode_set, we can't allow > that, so force enable vop in mode setting. >=20 > Signed-off-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/dr= m/rockchip/rockchip_drm_vop.c > index c65b454..7c07537 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -1110,6 +1110,7 @@ static void vop_crtc_mode_set_nofb(struct drm_crtc = *crtc) > u16 vact_end =3D vact_st + vdisplay; > uint32_t val; > =20 > + vop_crtc_enable(crtc); > /* > * If dclk rate is zero, mean that scanout is stop, > * we don't need wait any more. Have you considered simply moving everything into ->enable()? That's what I did for Tegra, for much the same reasons that you gave in the commit message. Doing so gives you a much simpler call graph. Really the only thing you need to do is move around the code, and perhaps a different way to get ahold of the display mode, but you can use the Tegra driver as a reference for how to do that. Thierry --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWXyKIAAoJEN0jrNd/PrOhnZsQAI9tEPgHUaaigVHr6+Mvy6vM ztw0zYhFSJg4JzMMCabP/6PmyTajONUR6Bbe0agbiyH1yyOPwnsq+EUerSftxCx3 76pzRJAp/Cghgr10wZEKPKfg2N31hxrR+e34HBIAlNY7Wbz6UHFJMcCE/EfWFbbE DMmkPe+eBG413mI42SjLqTDjUgBF+T9CeZ9Ap/5yDSfgsTKHnsOgaT8yOjuf+BeI zW+vPOdYSBmjBnF4iN32B9jwi9IZyG73yKPkJXUVGeeThZbYyWRT0N2GxnTb5414 ieoxwKJiu4/5DAz8AfaaVRxMSCz+xP8D2ZpwqZaAtURa0xBq9ATAAqn4IGnUudM3 jbgy0ll/wQZcBhKFMxsRVhDfFmwkLLI6Og5iu5Obnkk3GzC1ZPvZ2KBoywMK1uzc MmF+ZPGapQ9pDhTI1hitT/QhgIeJpX5iFAVB876Kf4ZTyz+21FnEvlSCkwcdxUTR t5vu6gytAx/kYfo3NI34+hIo7vki1IGHcplJwjMpwggbLhQfYmUHX/tmNNuHX4Bh boXSS8mlN+6gZPRJd4nu5mEpzJf7Pvd6JruWk7aRdbJvKlwzkwNHJxRecyGXKNzA zxQ7FuzzdS4V9Eeh+UIi5sIdUfGVSid+6Xb9Jiw2IVq2vt0/g8D+H7H3mlrVGagh NCSx4y96499VNUgnEciF =WhpD -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--