From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752502AbbLCQnv (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Dec 2015 11:43:51 -0500
Received: from mga14.intel.com ([192.55.52.115]:7290 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752410AbbLCQnt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Dec 2015 11:43:49 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,378,1444719600"; 
   d="scan'208";a="863999633"
Date: Thu, 3 Dec 2015 09:43:42 -0700
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Jeff Moyer <jmoyer@redhat.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>, xfs@oss.sgi.com,
        Brian Foster <bfoster@redhat.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: xfstest failure with xfs, dax and v4.4-rc3
Message-ID: <20151203164342.GA14849@linux.intel.com>
Mail-Followup-To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Dave Chinner <david@fromorbit.com>, Jeff Moyer <jmoyer@redhat.com>,
	xfs@oss.sgi.com, Brian Foster <bfoster@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20151201224346.GA15684@linux.intel.com>
 <20151201235158.GF19199@dastard>
 <x49k2owq3z6.fsf@segfault.boston.devel.redhat.com>
 <20151203065127.GB26718@dastard>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151203065127.GB26718@dastard>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 03, 2015 at 05:51:27PM +1100, Dave Chinner wrote:
> As it is, that test does not fail on my DAX testing on RAM disks.
> ISTR it failing up until recently, though. Yeah:
> 
> Last login: Tue Nov 17 08:45:55 2015 from 192.168.1.103
> $ cd ~/src/xfstests-dev; sudo mkfs.xfs -f /dev/ram0 ; sudo xfs_admin -U generate /dev/ram0 ; sudo MOUNT_OPTIONS="-o dax" ./check -g auto
> SECTION       -- xfs
> FSTYP         -- xfs (debug)
> PLATFORM      -- Linux/x86_64 test4 4.3.0-dgc+
> MKFS_OPTIONS  -- -f -bsize=4096 /dev/ram1
> MOUNT_OPTIONS -- -o dax /dev/ram1 /mnt/scratch
> ....
> generic/083 2s ... 1s
> _check_xfs_filesystem: filesystem on /dev/ram1 is inconsistent (c) (see /home/dave/src/xfstests-dev/results//xfs/generic/083.full)
> _check_xfs_filesystem: filesystem on /dev/ram1 is inconsistent (r) (see /home/dave/src/xfstests-dev/results//xfs/generic/083.full)
> ....
> 
> But as I ran earlier today when testing the ENOSPC fix:
> 
> PLATFORM      -- Linux/x86_64 test4 4.4.0-rc2-dgc+
> MKFS_OPTIONS  -- -f -bsize=4096 /dev/ram1
> MOUNT_OPTIONS -- -o dax /dev/ram1 /mnt/scratch
> ....
> generic/083 1s ... 2s
> ....
> 
> So I'm seeing that the current 4.4-rc2 + my local dev tree patches
> appear to have fixed whatever was causing generic/083 to fail
> here...

Yea, interesting, the patch you sent out yesterday:

xfs: Don't use reserved blocks for data blocks with DAX

Makes this issue disappear in my system as well.  Testing with v4.4-rc3
generic/083 fails 50% of the time or so in my setup, but with just that patch
added to v4.4-rc3 I can't make it fail.

> What version of xfsprogs are you using, Ross?

I'm currently using xfsprogs v4.3.0, but the failure occurred when I was using
v4.2.0 as well.