From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>
Cc: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v3] livepatch: Cleanup module page permission changes
Date: Thu, 3 Dec 2015 11:54:36 -0600 [thread overview]
Message-ID: <20151203175436.GD11394@treble.redhat.com> (raw)
In-Reply-To: <71aa85cf0ab95f95af8b2dcded2eba4e5bfa1874.1449162208.git.jpoimboe@redhat.com>
On Thu, Dec 03, 2015 at 11:07:28AM -0600, Josh Poimboeuf wrote:
> Calling set_memory_rw() and set_memory_ro() for every iteration of the
> loop in klp_write_object_relocations() is messy, inefficient, and
> error-prone.
>
> Change all the read-only pages to read-write before the loop and convert
> them back to read-only again afterwards.
>
> Suggested-by: Miroslav Benes <mbenes@suse.cz>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>
> Based on linux-next.
>
> - v3: use new module_{disable,enable}_ro() functions (in linux-next)
Please ignore this patch. I just realized that it conflicts with
Chris's patch set. I'll post v4 after Chris's gets merged.
--
Josh
prev parent reply other threads:[~2015-12-03 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 17:07 [PATCH v3] livepatch: Cleanup module page permission changes Josh Poimboeuf
2015-12-03 17:54 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203175436.GD11394@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox