From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] x86, perf: Remove warning for zero PEBS status
Date: Thu, 3 Dec 2015 22:28:33 +0100 [thread overview]
Message-ID: <20151203212833.GA17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1449177740-5422-1-git-send-email-andi@firstfloor.org>
On Thu, Dec 03, 2015 at 01:22:19PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> The recent change 75f80859b1 (... Robustify PEBS buffer drain)
> causes lots of warnings on different CPUs before Skylake
> when running PEBS intensive workloads.
>
> They can have a zero status field in the PEBS record when
> PEBS is racing with clearing of GLOBAl_STATUS.
Ah, so _that_ is the explanation! Please put that in a comment near that
code. This has long puzzled me.
Thanks for digging into that.
next prev parent reply other threads:[~2015-12-03 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 21:22 [PATCH 1/2] x86, perf: Remove warning for zero PEBS status Andi Kleen
2015-12-03 21:22 ` [PATCH 2/2] x86, perf: Allow zero PEBS status with only single active event Andi Kleen
2015-12-03 21:29 ` Peter Zijlstra
2016-01-06 18:50 ` [tip:perf/core] perf/x86: " tip-bot for Andi Kleen
2015-12-03 21:28 ` Peter Zijlstra [this message]
2016-01-06 18:50 ` [tip:perf/core] perf/x86: Remove warning for zero PEBS status tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203212833.GA17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox