From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754491AbbLCV2i (ORCPT ); Thu, 3 Dec 2015 16:28:38 -0500 Received: from casper.infradead.org ([85.118.1.10]:41031 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbbLCV2h (ORCPT ); Thu, 3 Dec 2015 16:28:37 -0500 Date: Thu, 3 Dec 2015 22:28:33 +0100 From: Peter Zijlstra To: Andi Kleen Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 1/2] x86, perf: Remove warning for zero PEBS status Message-ID: <20151203212833.GA17308@twins.programming.kicks-ass.net> References: <1449177740-5422-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449177740-5422-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 03, 2015 at 01:22:19PM -0800, Andi Kleen wrote: > From: Andi Kleen > > The recent change 75f80859b1 (... Robustify PEBS buffer drain) > causes lots of warnings on different CPUs before Skylake > when running PEBS intensive workloads. > > They can have a zero status field in the PEBS record when > PEBS is racing with clearing of GLOBAl_STATUS. Ah, so _that_ is the explanation! Please put that in a comment near that code. This has long puzzled me. Thanks for digging into that.