From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] checkpatch: false positive for commits with quote characters
Date: Thu, 3 Dec 2015 16:13:18 -0800 [thread overview]
Message-ID: <20151204001318.GA57739@google.com> (raw)
In-Reply-To: <20151117180336.GE8456@google.com>
Ping? I've hit some different false positives today on the same rule.
I'll stop bothering to report them if no one cares.
On Tue, Nov 17, 2015 at 10:03:36AM -0800, Brian Norris wrote:
> On Tue, Nov 17, 2015 at 09:48:27AM -0800, Joe Perches wrote:
> > On Mon, 2015-11-16 at 14:43 -0800, Brian Norris wrote:
> > > Hi,
> > >
> > > What is the Blessed (TM) style for referencing commits that have quote
> > > characters in their subject line? e.g., this commit:
> > >
> > > commit 43163022927b6e7d202a7e6f939c3f392465494d
> > > Author: Brian Norris <computersforpeace@gmail.com>
> > > Date: Tue May 19 14:38:22 2015 -0700
> > >
> > > mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"
> > >
> > > Checkpatch reports false positive errors like this:
> > >
> > > ERROR: Please use git commit description style 'commit <12+ chars of
> > > sha1> ("")'
> >
> > Hi Brian.
> >
> > What version of checkpatch are you using?
> >
> > Using linux-next:
> >
> > $ git log --stat -p -1 --format=email 43163022927b6e7d202a7e6f939c3f392465494d | ./scripts/checkpatch.pl --strict -
>
> I was referring to running checkpatch on this:
>
> https://lkml.org/lkml/2015/11/16/826
>
> which *referenced* commit 43163022927b6e7d202a7e6f939c3f392465494d.
> Sorry if that wasn't clear.
>
> See below,
> Brian
>
> $ curl http://patchwork.ozlabs.org/patch/545234/mbox/ | scripts/checkpatch.pl -
> % Total % Received % Xferd Average Speed Time Time Time Current
> Dload Upload Total Spent Left Speed
> 100 3741 0 3741 0 0 11525 0 --:--:-- --:--:-- --:--:-- 11510
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for "jedec,spi-nor"")'
> #17:
> Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for
>
> total: 1 errors, 0 warnings, 29 lines checked
>
> Your patch has style problems, please review.
>
> NOTE: Ignored message types: FILE_PATH_CHANGES
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
next prev parent reply other threads:[~2015-12-04 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 22:43 [BUG] checkpatch: false positive for commits with quote characters Brian Norris
2015-11-17 17:48 ` Joe Perches
2015-11-17 18:03 ` Brian Norris
2015-12-04 0:13 ` Brian Norris [this message]
2015-12-04 0:29 ` Joe Perches
2015-12-04 0:36 ` Joe Perches
2015-12-04 1:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204001318.GA57739@google.com \
--to=computersforpeace@gmail.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox