From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755412AbbLDIJH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Dec 2015 03:09:07 -0500
Received: from mail-wm0-f49.google.com ([74.125.82.49]:33842 "EHLO
	mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751519AbbLDIJF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Dec 2015 03:09:05 -0500
Date: Fri, 4 Dec 2015 09:09:01 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Xunlei Pang <xlpang@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>,
        Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] sched/core: Clear the root_domain cpumasks in
 init_rootdomain()
Message-ID: <20151204080901.GA26934@gmail.com>
References: <1449057179-29321-1-git-send-email-xlpang@redhat.com>
 <20151202123414.GB9928@worktop.ger.corp.intel.com>
 <565EEE3E.30301@redhat.com>
 <20151202162542.GT3816@twins.programming.kicks-ass.net>
 <565FAC78.3030205@redhat.com>
 <20151203082800.GA2321@gmail.com>
 <56602D19.5080308@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56602D19.5080308@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Xunlei Pang <xlpang@redhat.com> wrote:

> > Hm, is the alloc_cpumask_var() done in alloc_sched_domains() safe?
> 
> Until now, I haven't found any other similar issues, but I will check further.
> 
> >
> > At least the usage pattern in init_sched_domains() looks unsafe:
> >
> >         doms_cur = alloc_sched_domains(ndoms_cur);
> >         if (!doms_cur)
> >                 doms_cur = &fallback_doms;
> >         cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);

So is this pattern in init_sched_domains() correct, for OFFSTACK=y?

It looks wrong to me, as alloc_sched_domains() allocates an uninitialized cpumask 
via alloc_cpumask_var() and returns it:

cpumask_var_t *alloc_sched_domains(unsigned int ndoms)
{
        int i;
        cpumask_var_t *doms;

        doms = kmalloc(sizeof(*doms) * ndoms, GFP_KERNEL);
        if (!doms)
                return NULL;
        for (i = 0; i < ndoms; i++) {
                if (!alloc_cpumask_var(&doms[i], GFP_KERNEL)) {
                        free_sched_domains(doms, i);
                        return NULL;
                }
        }
        return doms;
}

and then this code:

> >         cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);

uses it without first clearing it.

So is this another such bug, or am I missing something?

Thanks,

	Ingo