public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Xunlei Pang <xlpang@redhat.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] sched/core: Clear the root_domain cpumasks in init_rootdomain()
Date: Fri, 4 Dec 2015 09:30:26 +0100	[thread overview]
Message-ID: <20151204083026.GA32345@gmail.com> (raw)
In-Reply-To: <20151204082703.GD17308@twins.programming.kicks-ass.net>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Dec 04, 2015 at 09:09:01AM +0100, Ingo Molnar wrote:
> > and then this code:
> > 
> > > >         cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
> > 
> > uses it without first clearing it.
> > 
> > So is this another such bug, or am I missing something?
> 
> It uses it as destination, it does a complete write of the mask.

ah, indeed! The cpumask primitive confused me.

Thanks,

	Ingo

  reply	other threads:[~2015-12-04  8:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 11:52 [PATCH] sched/core: Clear the root_domain cpumasks in init_rootdomain() Xunlei Pang
2015-12-02 12:34 ` Peter Zijlstra
2015-12-02 13:12   ` Xunlei Pang
2015-12-02 16:25     ` Peter Zijlstra
2015-12-03  2:44       ` Xunlei Pang
2015-12-03  8:28         ` Ingo Molnar
2015-12-03 11:52           ` Xunlei Pang
2015-12-04  8:09             ` Ingo Molnar
2015-12-04  8:27               ` Peter Zijlstra
2015-12-04  8:30                 ` Ingo Molnar [this message]
2015-12-04  8:28               ` Xunlei Pang
2015-12-04  8:30                 ` Ingo Molnar
2015-12-03  9:35         ` Peter Zijlstra
2015-12-04 11:52 ` [tip:locking/core] " tip-bot for Xunlei Pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204083026.GA32345@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    --cc=xlpang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox