Re: [PATCH] x86/rapl: Do not load in a guest

Borislav Petkov
2015-12-04T10:56:24Z

On Fri, Dec 04, 2015 at 11:41:03AM +0100, Paolo Bonzini wrote:
> No, please don't. Why do you need a wrmsr instead of a rdmsr? If
> there's no RAPL domains, the device doesn't load. On hypervisors,
> reading random MSRs is generally safe.

Well, we could not do anything, sure, that's an option too. It would
only be the annoying error message. Which is

pr_err("no valid rapl domains found in package %d\n", rp->id);

I guess we can tone that down as apparently it is not an error to
not have valid rapl domains anymore. Maybe kill it altogether:
rapl_detect_topology() will propagate the error and the driver won't
load...

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.