From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Wanpeng Li <kernellwp@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Luca Abeni <luca.abeni@unitn.it>,
linux-kernel@vger.kernel.org, Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v6] sched/deadline: fix earliest_dl.next logic
Date: Fri, 4 Dec 2015 11:11:44 +0100 [thread overview]
Message-ID: <20151204101144.GG17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151204095952.GB17354@e106622-lin>
On Fri, Dec 04, 2015 at 09:59:52AM +0000, Juri Lelli wrote:
> > + if (next_node)
> > + dl_rq->earliest_dl.next = rb_entry(next_node,
> > + struct task_struct, pushable_dl_tasks)->dl.deadline;
>
> Small nitpick, we are breaking 80 columns here, checkpatch should have
> complained. I guess a different indentation could help.
>
> Apart from this, I couldn't spot any more problems with this patch.
So I don't mind the occasional violation of that rule if it aids in
better readable code.
However, that should now have included {} because the statement is
multi-line. Coding style suggests we have braces for anything over 1
line. I'll make that edit when applying, no need to resend yet another
time :-)
> Acked-by: Juri Lelli <juri.lelli@arm.com>
Thanks, I'll try and get it queued later today.
next prev parent reply other threads:[~2015-12-04 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 9:42 [PATCH v6] sched/deadline: fix earliest_dl.next logic Wanpeng Li
2015-12-03 11:15 ` Luca Abeni
2015-12-04 9:59 ` Juri Lelli
2015-12-04 10:11 ` Peter Zijlstra [this message]
2015-12-28 9:40 ` Wanpeng Li
2016-01-06 18:48 ` [tip:sched/core] sched/deadline: Fix the " tip-bot for Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204101144.GG17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=kernellwp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=mingo@kernel.org \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox