From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Amy Wiles <amy.l.wiles@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Hannes Reinecke <hare@suse.de>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] x86/rapl: Do not load in a guest
Date: Fri, 4 Dec 2015 10:37:31 -0800 [thread overview]
Message-ID: <20151204103731.01a2d7fc@icelake> (raw)
In-Reply-To: <20151204182807.GN21177@pd.tnic>
On Fri, 4 Dec 2015 19:28:07 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Fri, Dec 04, 2015 at 10:16:10AM -0800, Jacob Pan wrote:
> > CPU model detection is the first level checking.
>
> And in the case of RAPL, the only checking you can do. This is why it
> should've had a CPUID bit.
>
I am 200% with you, all I can say is we are working on it. Look at the
pain in the driver for dealing with various quirks.
> > The error is about no valid domains (e.g. counters not working). So
> > the error on minnowboard board could be a real problem if you expect
> > to use RAPL.
>
> Right, and if you need to disable it there, you would need to add a
> quirk table looking at DMI strings or so. A CPUID bit might've been a
> bit better if BIOS update would clear it on those boards. Then, sw
> won't even try to load there.
who is gonna collect all the DMI strings? I don't think this is
scalable.
next prev parent reply other threads:[~2015-12-04 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 18:27 [PATCH] x86/rapl: Do not load in a guest Borislav Petkov
2015-12-03 18:38 ` Jacob Pan
2015-12-03 18:42 ` Borislav Petkov
2015-12-03 18:59 ` Jacob Pan
2015-12-03 23:32 ` Rafael J. Wysocki
2015-12-03 23:25 ` Borislav Petkov
2015-12-04 1:00 ` Rafael J. Wysocki
2015-12-04 7:42 ` Ingo Molnar
2015-12-04 8:22 ` Peter Zijlstra
2015-12-04 8:28 ` Ingo Molnar
2015-12-04 10:19 ` Borislav Petkov
2015-12-04 10:41 ` Paolo Bonzini
2015-12-04 10:56 ` Borislav Petkov
2015-12-04 11:53 ` Ingo Molnar
2015-12-04 17:46 ` Jacob Pan
2015-12-04 17:52 ` Paolo Bonzini
2015-12-04 18:04 ` Borislav Petkov
2015-12-04 18:16 ` Jacob Pan
2015-12-04 18:28 ` Borislav Petkov
2015-12-04 18:37 ` Jacob Pan [this message]
2015-12-04 19:41 ` Borislav Petkov
2015-12-04 17:51 ` Jacob Pan
2015-12-04 22:14 ` Peter Zijlstra
2015-12-04 22:39 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204103731.01a2d7fc@icelake \
--to=jacob.jun.pan@linux.intel.com \
--cc=acme@kernel.org \
--cc=amy.l.wiles@intel.com \
--cc=bp@alien8.de \
--cc=hare@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox