public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: kernel test robot <ying.huang@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
	lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
	linux-edac <linux-edac@vger.kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [lkp] [x86/mce] 81ffdcdd97: kmsg.CPU61:Package_temperature_above_threshold,cpu_clock_throttled(total_events=#)
Date: Fri, 4 Dec 2015 11:48:15 +0100	[thread overview]
Message-ID: <20151204104815.GA21529@pd.tnic> (raw)
In-Reply-To: <87vb8fqaag.fsf@yhuang-dev.intel.com>

On Fri, Dec 04, 2015 at 09:20:39AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit 81ffdcdd97d94110627caa81c23d5d780083731d ("x86/mce: Fix thermal throttling reporting after kexec")
> 
> This may be the intended behavior, just FYI.

Should be...

Let me get this straight - before this commit, the messages don't
appear, yes?

Looking at the hunk and AFAICT, it checks APIC_LVTTHMR[VEC] and it did
bail out if something was there != 0 before.

With this check removed, we go and actually init.

So I can imagine BIOS programming stuff in it already and us not even
initializing thermal throttling due to that. And this commit actually
*fixed* it on baremetal too.

But that would be crazy, BIOS would never do something like that?!</sarcasm>

Tony?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

       reply	other threads:[~2015-12-04 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87vb8fqaag.fsf@yhuang-dev.intel.com>
2015-12-04 10:48 ` Borislav Petkov [this message]
2015-12-04 18:25 ` [lkp] [x86/mce] 81ffdcdd97: kmsg.CPU61:Package_temperature_above_threshold,cpu_clock_throttled(total_events=#) Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204104815.GA21529@pd.tnic \
    --to=bp@suse.de \
    --cc=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ying.huang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox