From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932066AbbLDKs2 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Dec 2015 05:48:28 -0500
Received: from mx2.suse.de ([195.135.220.15]:52932 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752283AbbLDKs1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Dec 2015 05:48:27 -0500
Date: Fri, 4 Dec 2015 11:48:15 +0100
From: Borislav Petkov <bp@suse.de>
To: kernel test robot <ying.huang@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, lkp@01.org,
        LKML <linux-kernel@vger.kernel.org>,
        linux-edac <linux-edac@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>, Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [lkp] [x86/mce] 81ffdcdd97:
 kmsg.CPU61:Package_temperature_above_threshold,cpu_clock_throttled(total_events=#)
Message-ID: <20151204104815.GA21529@pd.tnic>
References: <87vb8fqaag.fsf@yhuang-dev.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87vb8fqaag.fsf@yhuang-dev.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 04, 2015 at 09:20:39AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> commit 81ffdcdd97d94110627caa81c23d5d780083731d ("x86/mce: Fix thermal throttling reporting after kexec")
> 
> This may be the intended behavior, just FYI.

Should be...

Let me get this straight - before this commit, the messages don't
appear, yes?

Looking at the hunk and AFAICT, it checks APIC_LVTTHMR[VEC] and it did
bail out if something was there != 0 before.

With this check removed, we go and actually init.

So I can imagine BIOS programming stuff in it already and us not even
initializing thermal throttling due to that. And this commit actually
*fixed* it on baremetal too.

But that would be crazy, BIOS would never do something like that?!</sarcasm>

Tony?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--