public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Seth Jennings <sjenning@redhat.com>,
	Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH v4] livepatch: Cleanup module page permission changes
Date: Fri, 4 Dec 2015 15:17:04 +0100	[thread overview]
Message-ID: <20151204141704.GI14230@pathway.suse.cz> (raw)
In-Reply-To: <9b321c4c2edeaff43f21040a883891a691fc1978.1449181535.git.jpoimboe@redhat.com>

On Thu 2015-12-03 16:33:26, Josh Poimboeuf wrote:
> Calling set_memory_rw() and set_memory_ro() for every iteration of the
> loop in klp_write_object_relocations() is messy, inefficient, and
> error-prone.
> 
> Change all the read-only pages to read-write before the loop and convert
> them back to read-only again afterwards.
> 
> Suggested-by: Miroslav Benes <mbenes@suse.cz>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

This patch looks fine to me.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Thanks,
Petr

  parent reply	other threads:[~2015-12-04 14:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 22:33 [PATCH v4] livepatch: Cleanup module page permission changes Josh Poimboeuf
2015-12-04  0:11 ` Jiri Kosina
2015-12-04  1:45   ` Rusty Russell
2015-12-04 21:54     ` Jiri Kosina
2015-12-04 13:27   ` Josh Poimboeuf
2015-12-04 13:30     ` Josh Poimboeuf
2015-12-04 21:57     ` Jiri Kosina
2015-12-04 22:07       ` Josh Poimboeuf
2015-12-04 14:17 ` Petr Mladek [this message]
2015-12-04 21:54 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204141704.GI14230@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=rusty@rustcorp.com.au \
    --cc=sjenning@redhat.com \
    --cc=vojtech@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox