From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754474AbbLDPkh (ORCPT ); Fri, 4 Dec 2015 10:40:37 -0500 Received: from muru.com ([72.249.23.125]:50827 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753334AbbLDPke (ORCPT ); Fri, 4 Dec 2015 10:40:34 -0500 Date: Fri, 4 Dec 2015 07:40:31 -0800 From: Tony Lindgren To: Sudeep Holla Cc: Linus Walleij , Grygorii Strashko , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Message-ID: <20151204154031.GG23396@atomide.com> References: <1448644860-29323-1-git-send-email-sudeep.holla@arm.com> <1448644860-29323-2-git-send-email-sudeep.holla@arm.com> <20151203181337.GV23396@atomide.com> <566090FC.1020502@arm.com> <20151203214013.GB23396@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203214013.GB23396@atomide.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [151203 13:41]: > * Sudeep Holla [151203 11:00]: > > > > I have added irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake > > which ensures it's marked for wakeup. > > Hmm well see the error I pasted in this thread, maybe that provides > more clues. The irq_set_irq_wake(pcs_soc->irq, state) in pcs_irq_set_wake does not look right to me as pcs_irq_set_wake toggles the irq_wake for each pin separately, not for the whole controller. I think all that can be left out with the snipped from Grygorii, and maybe also the lock_class_key changes. Regards, Tony