From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198AbbLDQOH (ORCPT ); Fri, 4 Dec 2015 11:14:07 -0500 Received: from mail.kernel.org ([198.145.29.136]:55858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753569AbbLDQOE (ORCPT ); Fri, 4 Dec 2015 11:14:04 -0500 Date: Fri, 4 Dec 2015 10:13:58 -0600 From: Rob Herring To: Enric Balletbo i Serra Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, treding@nvidia.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, airlied@linux.ie, gregkh@linuxfoundation.org, sjoerd.simons@collabora.co.uk, javier@dowhile0.org, span@analogixsemi.com, nathan.chung@mediatek.com, djkurtz@chromium.org, drinkcat@chromium.org, laurent.pinchart@ideasonboard.com, dan.carpenter@oracle.com, jb.tsai@mediatek.com, cawa.cheng@mediatek.com, eddie.huang@mediatek.com, cjiao@analogixsemi.com, emil.l.velikov@gmail.com Subject: Re: [PATCHv6 4/5] devicetree: Add new ANX7814 SlimPort transmitter binding. Message-ID: <20151204161358.GA6977@rob-hp-laptop> References: <1449218107-6590-1-git-send-email-enric.balletbo@collabora.com> <1449218107-6590-5-git-send-email-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449218107-6590-5-git-send-email-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2015 at 09:35:06AM +0100, Enric Balletbo i Serra wrote: > The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > designed for portable devices. > > You can add support to your board with current binding. > > Example: > > anx7814: anx7814@38 { > compatible = "analogix,anx7814"; > reg = <0x38>; > interrupt-parent = <&gpio0> > interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > pd-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>; > reset-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>; > v10-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; > ports { This and the example below should be just "port" I think. Otherwise: Acked-by: Rob Herring > anx7814_in: endpoint { > remote-endpoint = <&hdmi0_out>; > }; > }; > }; > > Signed-off-by: Enric Balletbo i Serra > --- > > Changes since last version (requested by Rob Herring) > - Specify how many ports and how many endpoints for each port > - Simplify to just port (dropping ports) > - For cable det use an interrupt instead (to a gpio controller) > > .../devicetree/bindings/video/bridge/anx7814.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/bridge/anx7814.txt > > diff --git a/Documentation/devicetree/bindings/video/bridge/anx7814.txt b/Documentation/devicetree/bindings/video/bridge/anx7814.txt > new file mode 100644 > index 0000000..4e68789 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/bridge/anx7814.txt > @@ -0,0 +1,39 @@ > +Analogix ANX7814 SlimPort (Full-HD Transmitter) > +----------------------------------------------- > + > +The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > +designed for portable devices. > + > +Required properties: > + > + - compatible : "analogix,anx7814" > + - reg : I2C address of the device > + - interrupt-parent : Should be the phandle of the interrupt controller > + that services interrupts for this device > + - interrupts : Should contain the cable detection interrupt > + - pd-gpios : Which GPIO to use for power down > + - reset-gpios : Which GPIO to use for reset > + > +Optional properties: > + > + - v10-gpios : Which GPIO to use for V10 control. > + - Video port for HDMI output, using the DT bindings defined in [1]. > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + anx7814: anx7814@38 { > + compatible = "analogix,anx7814"; > + reg = <0x38>; > + interrupt-parent = <&gpio0> > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > + pd-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>; > + v10-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>; > + ports { > + anx7814_in: endpoint { > + remote-endpoint = <&hdmi0_out>; > + }; > + }; > + }; > -- > 2.1.0 >