From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754672AbbLDS2S (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Dec 2015 13:28:18 -0500
Received: from mail.skyhub.de ([78.46.96.112]:56112 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751550AbbLDS2P (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Dec 2015 13:28:15 -0500
Date: Fri, 4 Dec 2015 19:28:07 +0100
From: Borislav Petkov <bp@alien8.de>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Amy Wiles <amy.l.wiles@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] x86/rapl: Do not load in a guest
Message-ID: <20151204182807.GN21177@pd.tnic>
References: <20151204074206.GB24827@gmail.com>
 <20151204082256.GC17308@twins.programming.kicks-ass.net>
 <20151204082823.GA31591@gmail.com>
 <20151204101954.GA21177@pd.tnic>
 <56616DBF.8040900@redhat.com>
 <20151204105617.GB21177@pd.tnic>
 <20151204115335.GB15308@gmail.com>
 <20151204094642.4c5e63e0@icelake>
 <20151204180426.GM21177@pd.tnic>
 <20151204101610.34582aa2@icelake>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151204101610.34582aa2@icelake>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 04, 2015 at 10:16:10AM -0800, Jacob Pan wrote:
> CPU model detection is the first level checking.

And in the case of RAPL, the only checking you can do. This is why it
should've had a CPUID bit.

> The error is about no valid domains (e.g. counters not working). So
> the error on minnowboard board could be a real problem if you expect
> to use RAPL.

Right, and if you need to disable it there, you would need to add a
quirk table looking at DMI strings or so. A CPUID bit might've been a
bit better if BIOS update would clear it on those boards. Then, sw won't
even try to load there.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.