From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756396AbbLDVJV (ORCPT ); Fri, 4 Dec 2015 16:09:21 -0500 Received: from down.free-electrons.com ([37.187.137.238]:38636 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755974AbbLDVJU (ORCPT ); Fri, 4 Dec 2015 16:09:20 -0500 Date: Fri, 4 Dec 2015 22:09:19 +0100 From: Antoine Tenart To: Jisheng Zhang Cc: kishon@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] phy: berlin-usb: don't set device's driver_data Message-ID: <20151204210919.GB7200@kwain> References: <1449237421-5552-1-git-send-email-jszhang@marvell.com> <1449237421-5552-3-git-send-email-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw" Content-Disposition: inline In-Reply-To: <1449237421-5552-3-git-send-email-jszhang@marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XOIedfhf+7KOe/yw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote: > After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and > use it"), we get the address of priv by phy_get_drvdata(), so there's > no need to set device's driver_data any more. This patch removes the > call of platform_set_drvdata(). >=20 > Signed-off-by: Jisheng Zhang Acked-by: Antoine Tenart > --- > drivers/phy/phy-berlin-usb.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c > index 7bbb473..2017751 100644 > --- a/drivers/phy/phy-berlin-usb.c > +++ b/drivers/phy/phy-berlin-usb.c > @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_devic= e *pdev) > return PTR_ERR(phy); > } > =20 > - platform_set_drvdata(pdev, priv); > phy_set_drvdata(phy, priv); > =20 > phy_provider =3D > --=20 > 2.6.2 >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --XOIedfhf+7KOe/yw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIbBAEBCgAGBQJWYgD+AAoJEFxNi8it27zYE5MP+KasJTBwNZGJAWw1xNBopzqm +l2wFHQCf3hh4R3BP8YEJooUT8CmSOWkX0/0eWdobcE8eQkMZgjey5gryBHqxmw1 cQNKSnmcLweH1MkhkhFEZtivbkYo7IzKOGuqVGIFeSg2xQaTnDTSaZs5eSp6am/U exc/zXTzsRMqkRLMKhl3DcFth7MfMgSjsIqd0vJ8wy0ATktyjz/ZYeV3toXOFzOa Q5vAzpmPne9rnrVWH7E2LcWddJEtI/902NjfGULT1WUXrlcQgkqAGm98mHNmvoWz vNL2DhTpNAL7/gZAyg6nJ79GWvvRCNLM7amseGIZkAjhVamMyzEaYPycdfktwY/h qOm3JNqVOCoxBfrA5jx4IJ6T6y/8dEHlCrGWJOBtGEgEeew1LM36+AzKaT/ZtijA ZEXeUifI0xonUfVvEeasQjdjwmck+Qw/zm+ZVxedMoMbbaGLYdST+53DaL5pMf/8 2oMC2DLwsPofIzi045zc6kOUgT9QSxn/toc3bjbYBBmqixnEclCXIg8ay+5IcS8/ pmwsdouaqOWLN8vOdFcBgKRFlKxvGuQULLLXtUoZMDKYaC8Femft52ak3ciXMGFX mm5BjZJjfLvy5AyKAmlbRFjXIzmojmlFjgGDsKePkSGyAWUxbK1+LwcCFmOWAqu2 3WthNnavEFfctYM+msc= =XUD1 -----END PGP SIGNATURE----- --XOIedfhf+7KOe/yw--