From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753909AbbLEUDX (ORCPT ); Sat, 5 Dec 2015 15:03:23 -0500 Received: from mail.skyhub.de ([78.46.96.112]:57576 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbbLEUDW (ORCPT ); Sat, 5 Dec 2015 15:03:22 -0500 Date: Sat, 5 Dec 2015 21:03:13 +0100 From: Borislav Petkov To: Thomas Gleixner Cc: X86 ML , LKML , David Sterba , Herbert Xu , Peter Zijlstra , Matt Mackall , Chris Mason , Josef Bacik Subject: Re: [PATCH 3/4] x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros Message-ID: <20151205200313.GB18105@pd.tnic> References: <1448982023-19187-1-git-send-email-bp@alien8.de> <1448982023-19187-4-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2015 at 08:59:45PM +0100, Thomas Gleixner wrote: > On Tue, 1 Dec 2015, Borislav Petkov wrote: > > -#define cpu_has_ht boot_cpu_has(X86_FEATURE_HT) > > tip/arch/x86/include/asm/smp.h: In function ‘cpu_has_ht_siblings’: > tip/arch/x86/include/asm/smp.h:28:17: error: ‘cpu_has_ht’ undeclared (first use in this function) > has_siblings = cpu_has_ht && smp_num_siblings > 1; Yeah, this series needs to go ontop of ed29210cd6a6 ("x86: Remove unused function cpu_has_ht_siblings()") which is in tip/x86/cleanups. BTW, thanks for taking a look, I'll send an updated one removing the static_cpu_has_safe() calls as you suggested in your other mail. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.