From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754803AbbLFDp7 (ORCPT ); Sat, 5 Dec 2015 22:45:59 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:53196 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754539AbbLFDoS (ORCPT ); Sat, 5 Dec 2015 22:44:18 -0500 Message-Id: <20151206013144.776033284@telegraphics.com.au> User-Agent: quilt/0.50-1 Date: Sun, 06 Dec 2015 12:32:38 +1100 From: Finn Thain To: "James E.J. Bottomley" , Michael Schmitz , , , Cc: Ondrej Zary Subject: [PATCH v2 72/72] ncr5380: Fix pseudo DMA transfers on 53C400 References: <20151206013126.995379403@telegraphics.com.au> Content-Disposition: inline; filename=ncr5380-fix-53c400-pdma Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ondrej Zary Pseudo-DMA (PDMA) has been broken for ages, resulting in hangs on 53C400-based cards. According to 53C400 datasheet, PDMA transfer length must be a multiple of 128. Check if that's true and use PIO if it's not. This makes PDMA work on 53C400 (Canon FG2-5202). Signed-off-by: Ondrej Zary Signed-off-by: Finn Thain --- drivers/scsi/g_NCR5380.c | 4 ++++ 1 file changed, 4 insertions(+) Index: linux/drivers/scsi/g_NCR5380.c =================================================================== --- linux.orig/drivers/scsi/g_NCR5380.c 2015-12-06 12:30:58.000000000 +1100 +++ linux/drivers/scsi/g_NCR5380.c 2015-12-06 12:31:23.000000000 +1100 @@ -702,6 +702,10 @@ static int generic_NCR5380_dma_xfer_len( !(cmd->SCp.this_residual % transfersize)) transfersize = 32 * 1024; + /* 53C400 datasheet: non-modulo-128-byte transfers should use PIO */ + if (transfersize % 128) + transfersize = 0; + return transfersize; }