Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex ADJ_SETOFFSET to avoid overflow

Thomas Gleixner
2015-12-07T20:17:26Z

On Mon, 7 Dec 2015, John Stultz wrote:
> On Mon, Dec 7, 2015 at 12:11 PM, John Stultz <john.stultz@linaro.org> wrote:
> > diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> > index 99188ee..a37222b 100644
> > --- a/kernel/time/timekeeping.c
> > +++ b/kernel/time/timekeeping.c
> > @@ -1986,6 +1986,7 @@ int do_adjtimex(struct timex *txc)
> >
> > if (txc->modes & ADJ_SETOFFSET) {
> > struct timespec delta;
> > +
> > delta.tv_sec = txc->time.tv_sec;
> > delta.tv_nsec = txc->time.tv_usec;
> > if (!(txc->modes & ADJ_NANO))
>
> Gah. Except for this needless whitespace. Ignore that please.

It's needless for this patch, but correct by itself :)