From: Sanidhya Solanki <jpage.lkml@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header
Date: Mon, 7 Dec 2015 05:09:19 -0500 [thread overview]
Message-ID: <20151207050919.28464160@gmail.com> (raw)
In-Reply-To: <20151207060731.GB4122@sudip-pc>
On Mon, 7 Dec 2015 11:37:31 +0530
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> And you moved skein_256_process_block() from skein_block.c to a header
> file. Is skein_256_process_block() a macro?
No, it is not a macro, it is a conditional. But as other conditionals
was already included in the header file, I felt that it was
appropriate to move other conditionals as well. However, I will undo
that and test a patch, which I can send to you after making sure it
does not get mangled.
Thanks
prev parent reply other threads:[~2015-12-07 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 11:35 [PATCH] Staging: Skein: Moved macros from skein_block.c to header Sanidhya Solanki
2015-12-05 16:43 ` kbuild test robot
2015-12-06 3:25 ` Sanidhya Solanki
2015-12-07 6:07 ` Sudip Mukherjee
2015-12-07 10:09 ` Sanidhya Solanki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207050919.28464160@gmail.com \
--to=jpage.lkml@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox