From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932603AbbLGOKa (ORCPT ); Mon, 7 Dec 2015 09:10:30 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33127 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932204AbbLGOK0 (ORCPT ); Mon, 7 Dec 2015 09:10:26 -0500 Date: Mon, 7 Dec 2015 05:09:19 -0500 From: Sanidhya Solanki To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header Message-ID: <20151207050919.28464160@gmail.com> In-Reply-To: <20151207060731.GB4122@sudip-pc> References: <20151205063529.780bf436@gmail.com> <201512060035.GGCfWsZs%fengguang.wu@intel.com> <20151205222516.13a8baf6@gmail.com> <20151207060731.GB4122@sudip-pc> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2015 11:37:31 +0530 Sudip Mukherjee wrote: > And you moved skein_256_process_block() from skein_block.c to a header > file. Is skein_256_process_block() a macro? No, it is not a macro, it is a conditional. But as other conditionals was already included in the header file, I felt that it was appropriate to move other conditionals as well. However, I will undo that and test a patch, which I can send to you after making sure it does not get mangled. Thanks